From 8695f1fc6e69ef8fdb9c02b2d5ddd279169ca2e7 Mon Sep 17 00:00:00 2001
From: Oskar Weigl <oskar.weigl@gmail.com>
Date: Tue, 19 Mar 2019 07:10:04 +0100
Subject: [PATCH] Apply comment suggestions from code review

Co-Authored-By: Wetmelon <Wetmelon@users.noreply.github.com>
---
 Firmware/Board/v3/Src/freertos.c              | 1 +
 Firmware/MotorControl/main.cpp                | 1 -
 Firmware/fibre/cpp/include/fibre/protocol.hpp | 2 ++
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/Firmware/Board/v3/Src/freertos.c b/Firmware/Board/v3/Src/freertos.c
index 3c34849b..ac6c6de9 100644
--- a/Firmware/Board/v3/Src/freertos.c
+++ b/Firmware/Board/v3/Src/freertos.c
@@ -189,6 +189,7 @@ void MX_FREERTOS_Init(void) {
 
   init_deferred_interrupts();
 
+  // Load persistent configuration (or defaults)
   load_configuration();
   /* USER CODE END RTOS_SEMAPHORES */
 
diff --git a/Firmware/MotorControl/main.cpp b/Firmware/MotorControl/main.cpp
index 1a1f331d..427792b3 100644
--- a/Firmware/MotorControl/main.cpp
+++ b/Firmware/MotorControl/main.cpp
@@ -117,7 +117,6 @@ void vApplicationIdleHook(void) {
 }
 
 int odrive_main(void) {
-    // Load persistent configuration (or defaults)
 
 #if HW_VERSION_MAJOR == 3 && HW_VERSION_MINOR >= 3
     if (board_config.enable_i2c_instead_of_can) {
diff --git a/Firmware/fibre/cpp/include/fibre/protocol.hpp b/Firmware/fibre/cpp/include/fibre/protocol.hpp
index 664ba20d..498d5172 100644
--- a/Firmware/fibre/cpp/include/fibre/protocol.hpp
+++ b/Firmware/fibre/cpp/include/fibre/protocol.hpp
@@ -86,6 +86,7 @@ typedef struct {
 
 template<typename T, typename = typename std::enable_if_t<!std::is_const<T>::value>>
 inline size_t write_le(T value, uint8_t* buffer){
+    //TODO: add static_assert that this is still a little endian machine
     std::memcpy(&buffer[0], &value, sizeof(value));
     return sizeof(value);
 }
@@ -106,6 +107,7 @@ inline size_t write_le<float>(float value, uint8_t* buffer) {
 
 template<typename T>
 inline size_t read_le(T* value, const uint8_t* buffer){
+    // TODO: add static_assert that this is still a little endian machine
     std::memcpy(value, buffer, sizeof(*value));
     return sizeof(*value);
 }