From f026adec839378753e67f578c5dab758a2c27cbc Mon Sep 17 00:00:00 2001 From: Leithen Date: Tue, 31 Mar 2026 14:53:45 -0600 Subject: [PATCH] Fix comment on PR workflow (#13188) * remove specific node version so default is 24 * change success to completed in comment pr workflow --- .github/workflows/comment-pr.yml | 2 +- .github/workflows/fpb-lint.yml | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/comment-pr.yml b/.github/workflows/comment-pr.yml index a63b789cd..f0d920d5a 100644 --- a/.github/workflows/comment-pr.yml +++ b/.github/workflows/comment-pr.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest if: > ${{ github.event.workflow_run.event == 'pull_request' && - github.event.workflow_run.conclusion == 'success' }} + github.event.workflow_run.conclusion == 'completed' }} steps: - name: 'Download artifact' uses: actions/github-script@v8 diff --git a/.github/workflows/fpb-lint.yml b/.github/workflows/fpb-lint.yml index e7d09fe69..be5a34e1c 100644 --- a/.github/workflows/fpb-lint.yml +++ b/.github/workflows/fpb-lint.yml @@ -14,11 +14,9 @@ jobs: - uses: actions/checkout@v5 - name: Use Node.js uses: actions/setup-node@v6 - with: - node-version: '16.x' - run: npm install -g free-programming-books-lint - - name: Pull Request + - name: Run linter run: | fpb-lint books casts courses more &> output.log @@ -29,7 +27,8 @@ jobs: echo ${{ github.event.pull_request.html_url }} > ./pr/PRurl cat output.log | sed -E 's:/home/runner/work/free-programming-books/|⚠.+::' | uniq > ./pr/error.log - - uses: actions/upload-artifact@v7 + - name: Upload artifact + uses: actions/upload-artifact@v7 if: always() with: name: pr